Re: [PATCH 3/7] coccinelle: zalloc-simple: drop the kmem_alloc rules

[Julia Lawall]

On Mon, 24 Aug 2026, Sang-Heon Jeon wrote:

> - kmem_alloc() was removed by commit f078d4ea8276
>   ("xfs: convert kmem_alloc() to kmalloc()")
>
> - kmem_zalloc() was removed by commit 10634530f7ba
>   ("xfs: convert kmem_zalloc() to kzalloc()")
>
> So drop the kmem_alloc rules.
>
> No functional change.

Applied

>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@xxxxxxxxx>
> ---
>  .../coccinelle/api/alloc/zalloc-simple.cocci  | 41 +------------------
>  1 file changed, 1 insertion(+), 40 deletions(-)
>
> diff --git a/scripts/coccinelle/api/alloc/zalloc-simple.cocci b/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> index d66c45356691..ae1d39e71e31 100644
> --- a/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> +++ b/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> @@ -35,7 +35,7 @@ statement S;
>  @@
>
>  * x = (T)\(kmalloc(E1, ...)\|vmalloc(E1)\|dma_alloc_coherent(...,E1,...)\|
> -  kmalloc_node(E1, ...)\|kmem_cache_alloc(...)\|kmem_alloc(E1, ...)\|
> +  kmalloc_node(E1, ...)\|kmem_cache_alloc(...)\|
>    devm_kmalloc(...,E1,...)\|kvmalloc(E1, ...)\|kvmalloc_node(E1,...)\);
>    if ((x==NULL) || ...) S
>  * memset((T2)x,0,E1);
> @@ -88,15 +88,6 @@ statement S;
>  - x = (T)kmem_cache_alloc(E3,E4);
>  + x = (T)kmem_cache_zalloc(E3,E4);
>  |
> -- x = kmem_alloc(E1,E2);
> -+ x = kmem_zalloc(E1,E2);
> -|
> -- x = (T *)kmem_alloc(E1,E2);
> -+ x = kmem_zalloc(E1,E2);
> -|
> -- x = (T)kmem_alloc(E1,E2);
> -+ x = (T)kmem_zalloc(E1,E2);
> -|
>  - x = devm_kmalloc(E2,E1,E3);
>  + x = devm_kzalloc(E2,E1,E3);
>  |
> @@ -290,36 +281,6 @@ x << r4.x;
>  msg="WARNING: kmem_cache_zalloc should be used for %s, instead of kmem_cache_alloc/memset" % (x)
>  coccilib.report.print_report(p[0], msg)
>
> -//-----------------------------------------------------------------
> -@r5 depends on org || report@
> -type T, T2;
> -expression x;
> -expression E1,E2;
> -statement S;
> -position p;
> -@@
> -
> - x = (T)kmem_alloc@p(E1,E2);
> - if ((x==NULL) || ...) S
> - memset((T2)x,0,E1);
> -
> -@script:python depends on org@
> -p << r5.p;
> -x << r5.x;
> -@@
> -
> -msg="%s" % (x)
> -msg_safe=msg.replace("[","@(").replace("]",")")
> -coccilib.org.print_todo(p[0], msg_safe)
> -
> -@script:python depends on report@
> -p << r5.p;
> -x << r5.x;
> -@@
> -
> -msg="WARNING: kmem_zalloc should be used for %s, instead of kmem_alloc/memset" % (x)
> -coccilib.report.print_report(p[0], msg)
> -
>  //-----------------------------------------------------------------
>  @r6 depends on org || report@
>  type T, T2;
> --
> 2.43.0
>
>