Re: [PATCH v7 5/6] tools/mm: make gup_bench a benchmark only tool

From: Mike Rapoport

Date: Mon Aug 24 2026 - 04:00:49 EST


On Thu, 13 Aug 2026 23:42:29 +0530, Sarthak Sharma <sarthak.sharma@xxxxxxx> wrote:
> Remove the functional modes (GUP_BASIC_TEST, PIN_BASIC_TEST and
> DUMP_USER_PAGES_TEST) from gup_bench. Drop the kselftest dependency
> and use normal diagnostics and exit statuses.
>
> When no arguments are supplied, run a single GUP_FAST_BENCHMARK
> with the existing default values. Let users select other
> configurations through command-line options. Report ioctl failures
> and handle errors without relying on assert().
>
> [...]

Acked-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>

--
Sincerely yours,
Mike.