Re: [PATCH v2 0/3] Add driver for Invensense ICM42370P accelerometer

[Kanak Shilledar]

Hi Jean-Baptiste,

On Thu, 2026-08-20 at 15:19 +0000, Jean-Baptiste Maneyrol wrote:
> > 
> > ________________________________________
> > From: Kanak Shilledar <kanak.shilledar@xxxxxxxx>
> > Sent: Thursday, August 13, 2026 14:26
> > To: Jonathan Cameron; David Lechner; Nuno Sá; Andy Shevchenko; Rob
> > Herring; Krzysztof Kozlowski; Conor Dooley; Henrik Grimler; Jean-
> > Baptiste Maneyrol
> > Cc: linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> > linux-kernel@xxxxxxxxxxxxxxx; kernel@xxxxxxxx; Kanak Shilledar
> > Subject: [PATCH v2 0/3] Add driver for Invensense ICM42370P
> > accelerometer
> > 
> > Invensense ICM42370P is a high performance MEMS MotionTracking 3-
> > axis accelerometer. It supports I2C, I3C and SPI protocols. It has
> > a 2. 25kB FIFO and two programmable interrupts with support for
> 
> Hello Kanak,
> 
> ICM-42370-P is completely similar to ICM-42607, except that it is
> accelerometer
> only. There is no need to write a completely new driver, you can add
> support
> of ICM-42370-P inside the existing inv_icm42607 driver.
> 
> inv_icm42607 driver is lacking a lot of functionalities, like buffer
> support.
> It explains why there is no support for MREG registers.
> 
> I recommend you add first basic support of ICM-42370-P inside
> existing inv_icm42607
> driver, and then add new functionalities like buffer support in this
> driver.
> There is really no need to write a new driver here. For MREG
> registers support, you
> can have a look inside inv_icm45600 that is using the same mechanism.
> 
> Thanks,
> JB

Thanks for going through the code. I didn't notice the ICM42607 in the
mailing list. I will add support for ICM42370 to that driver instead of
creating a new driver. I will have a patchset for basic support and
then incremental patches for implementing more features (like buffer).

Thanks and Regards,
Kanak Shilledar

Attachment: signature.asc
Description: This is a digitally signed message part