Re: [PATCH v4 3/4] power: sequencing: Add Renesas RZ/G3L Power Ready driver

[Geert Uytterhoeven]

Hi Biju,

On Wed, 19 Aug 2026 at 21:13, Biju <biju.das.au@xxxxxxxxx> wrote:
> From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> Add a power sequencing driver for the Renesas RZ/G3L PWRRDY module,
> which signals power readiness for various IPs (USB, DSI, CSI etc.) on the
> SoC. The driver binds as an auxiliary device to the parent SYSC driver,
> using its regmap to toggle the SYS_PWRRDY_N register bits, and exposes
> {usb,dsi,csi}-pwrrdy pwrseq targets.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---
> v3->v4:
>  * Replace the large of_device_id structures by C strings, and
>    using of_device_is_compatible() will reduce kernel size.
>  * Replaced of_device.h -> of.h
>  * Dropped local variable pwrseq from pwrseq_rzg3l_pwrrdy_probe().

Thanks for the update!

> --- /dev/null
> +++ b/drivers/power/sequencing/pwrseq-renesas-pwrrdy.c

> +static int pwrseq_rzg3l_pwrrdy_match(struct pwrseq_device *pwrseq,
> +                                    struct device *dev)
> +{
> +       if (of_device_is_compatible(dev->of_node, "renesas,r9a08g046-usbphy-ctrl") ||
> +           of_device_is_compatible(dev->of_node, "renesas,r9a08g046-mipi-dsi"))
> +               return PWRSEQ_MATCH_OK;

Nit: of_device_compatible_match() handled multiple entries.

Sorry, my fault, I accidentally copied and paste the wrong function
name in my review of v3.

> +
> +       return PWRSEQ_NO_MATCH;
> +}

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds