Re: [PATCH v6 2/2] input: misc: Add Qualcomm SPMI PMIC haptics driver

[Fenglin Wu]

On 8/17/2026 8:08 PM, David Heidelberg wrote:
>> +static const struct dev_pm_ops qcom_haptics_pm_ops = {
>> +	SYSTEM_SLEEP_PM_OPS(qcom_haptics_suspend, qcom_haptics_resume)
>> +	RUNTIME_PM_OPS(qcom_haptics_runtime_suspend, qcom_haptics_runtime_resume,
>> +		       NULL)
>> +};
>> +
>> +static const struct of_device_id qcom_haptics_of_match[] = {
>> +	{ .compatible = "qcom,spmi-haptics" },
> I assume this won't work for the Snapdragon 845 (and related arch) SPMI haptics.
> 
> Should be the assigned compatible (and relevant data) wired to the PMIH0108 
> compatible only?
> 
At the moment, this only works for haptics inside pmih0108 PMIC, which
contains the newest haptics module among Qcom PMICs. That said, with
some code changes, it should also support the older haptics modules in
pm8350b, pm8550b, and pm8750b, since those PMICs all support DIRECT_PLAY
and FIFO play modes. I expect this change to be applied first, and then
I or someone else can work on adding support for the older haptics
modules in the same driver.

It might be very difficult to support the haptics module inside pmi8998
which is used on SDM845 platform, as it has very different control logic
than the newer ones.

Thanks
Fenglin
> Thanks
> David
> 
> P.S. I'll be upstreaming SPMI haptics in approximatelly 2 months for the older 
> chips, please feel free to +Cc me on followups! 🙂
> 
>> +	{ }
>> +};
>> +MODULE_DEVICE_TABLE(of, qcom_haptics_of_match);
>> +
>> +static struct platform_driver qcom_haptics_driver = {