Re: [RFC PATCH] fat: add noflush mount option

[OGAWA Hirofumi]

David Timber <dxdt@xxxxxxxxxxxx> writes:


[...]

>>> @@ -1110,6 +1114,7 @@ const struct fs_parameter_spec fat_param_spec[] = {
>>>  	fsparam_flag	("debug",	Opt_debug),
>>>  	fsparam_flag	("sys_immutable", Opt_immutable),
>>>  	fsparam_flag	("flush",	Opt_flush),
>>> +	fsparam_flag	("noflush",	Opt_noflush),
>> fsparam_flag() is not including the "noflush" too?
> I think I should use fsparam_flag_no() here. My bad.
>
> It seems that you don't object to the idea. That's a good start!
>
> If we want to do this, the
> documentation(Documentation/filesystems/vfat.rst and mount(8)) should be
> updated, too. fyi, `udisksctl mount -o` won't accept "noflush" so
> that'll have to be fixed, too. Also have to make sure if "noflush" is
> used in fstab, udisks2 overrides the system default settings.

Well, with a your patch, just remounting without "flush" option doesn't
remove flush?  And this is a user visible change more or less, so if
there is an objection from users, then it will be dropped.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>