Re: [PATCH 07/12] dt-bindings: i2c: dw: Add compatible for UltraRISC DP1000 SoC

From: Jia Wang

Date: Tue Aug 25 2026 - 04:47:37 EST


On 2026-08-24 18:14 +0100, Conor Dooley wrote:
> On Mon, Aug 24, 2026 at 06:07:29PM +0100, Conor Dooley wrote:
> > On Mon, Aug 24, 2026 at 01:54:20PM +0800, Jia Wang via B4 Relay wrote:
> > > From: Jia Wang <wangjia@xxxxxxxxxxxxx>
> > >
> > > Add the SoC-specific compatible string and use the generic one as fallback
> > > for the UltraRISC DP1000 I2C controller.
> > >
> > > Signed-off-by: Jia Wang <wangjia@xxxxxxxxxxxxx>
> >
> > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> > pw-bot: not-applicable
>
> Same here, I was too hasty - please add some constraints like clocks
> being required etc.
>

Thanks for the review.

The existing schema already limits each DP1000 I2C controller to one
register range. In the next version, I will require two clocks and the
corresponding clock names.

Best regards,
Jia Wang