Re: [PATCH 08/12] dt-bindings: net: snps,dwmac: Add compatible for UltraRISC DP1000 SoC

[Jia Wang]

On 2026-08-24 18:13 +0100, Conor Dooley wrote:
> On Mon, Aug 24, 2026 at 06:09:48PM +0100, Conor Dooley wrote:
> > On Mon, Aug 24, 2026 at 01:54:21PM +0800, Jia Wang via B4 Relay wrote:
> > > From: Jia Wang <wangjia@xxxxxxxxxxxxx>
> > > 
> > > Add the SoC-specific compatible string for the UltraRISC DP1000 GMAC
> > > controller to the DesignWare MAC binding.
> > > 
> > > Signed-off-by: Jia Wang <wangjia@xxxxxxxxxxxxx>
> > 
> > The dts may not be right, but I am also a bit concerned here.
> > 
> > This binding permits 100s of combinations of properties, of which only
> > a very limited set can be correct for your device. Just adding the
> > compatible permits all of this variation.
> > 
> > Please add some restrictions.
> 
> In fact, it's particularly bad here because you don't even restrict
> which fallback compatibles are used, so there's no guidance on what
> version of the IP is even in use!
> 

I have rechecked the DTS against the hardware. The controller uses a
DesignWare GMAC IP from the 5.20 series, with "snps,dwmac-5.20" as its
version-specific fallback.

In the next version, I will restrict the fallback compatibles and add
DP1000-specific constraints for its hardware resources.

> > 
> > pw-bot: changes-requested
> > 
> > Thanks,
> > Conor.
> >

Best regards,
Jia Wang
 
> > > ---
> > >  Documentation/devicetree/bindings/net/snps,dwmac.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > index 2449311c6d28..2ed4564ae99d 100644
> > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > @@ -119,6 +119,7 @@ properties:
> > >          - starfive,jh7110-dwmac
> > >          - tesla,fsd-ethqos
> > >          - thead,th1520-gmac
> > > +        - ultrarisc,dp1000-gmac
> > >  
> > >    reg:
> > >      minItems: 1
> > > 
> > > -- 
> > > 2.34.1
> > > 
> > > 
> > > 
> > > _______________________________________________
> > > linux-riscv mailing list
> > > linux-riscv@xxxxxxxxxxxxxxxxxxx
> > > http://lists.infradead.org/mailman/listinfo/linux-riscv
> 
>