Re: [PATCH] arm64: dts: renesas: Use hyphens in node names

[Geert Uytterhoeven]

Hi Krzysztof,

On Sat, 22 Aug 2026 at 09:58, Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxxxxxxxx> wrote:
> DTS coding style encourages to use hyphens instead of underscores in
> node names. DTC W=2 warns about underscores. Improve existing code
> because apparently people copy it instead of following DTS coding style
> for new submissions.
>
> Semi-manual validation by checking if no new nodes appeared:
>
>   $ for i in dts-old/*/*dtb dts-old/*/*/*dtb; do echo $i; fdtdump ${i} > ${i}.fdt ; fdtdump dts-new/${i#dts-old/} > dts-new/${i#dts-old/}.fdt ; diff -ubB ${i}.fdt dts-new/${i#dts-old/}.fdt ; done | grep -v ' {'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/gray-hawk-single.dtsi
> +++ b/arch/arm64/boot/dts/renesas/gray-hawk-single.dtsi

> @@ -696,7 +696,7 @@ i2c3_pins: i2c3 {
>                 function = "i2c3";
>         };
>
> -       irq0_pins: irq0_pins {
> +       irq0_pins: irq0-pins {

This one shouldn't have used a "_pins" suffix in the first place.
I will sneak in that change while applying ;-)

>                 groups = "intc_ex_irq0_a";
>                 function = "intc_ex";
>         };

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-devel for v7.4.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds