Re: [PATCH net] net: fix spurious TX timeout after dev_activate()

[Breno Leitao]

On Tue, Aug 25, 2026 at 10:47:13AM +0200, Paolo Abeni wrote:
> On 8/24/26 5:13 PM, Nicolai Buchwitz wrote:
> >> diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
> >> index ef2b4bf515641..4539dc2c6d380 100644
> >> --- a/net/sched/sch_generic.c
> >> +++ b/net/sched/sch_generic.c
> >> @@ -1278,7 +1278,7 @@ static void transition_one_qdisc(struct 
> >> net_device *dev,
> >>
> >>  	rcu_assign_pointer(dev_queue->qdisc, new_qdisc);
> >>  	if (need_watchdog_p) {
> >> -		WRITE_ONCE(dev_queue->trans_start, 0);
> >> +		WRITE_ONCE(dev_queue->trans_start, jiffies);
> >>  		*need_watchdog_p = 1;
> >>  	}
> >>  }
> > 
> > Follow up or v2: netif_trans_update() in dev_activate() now seems 
> > redundant?
> 
> IMHO should be a follow-up.

Oops, I replied to the other email too early. I'll respin this one and
send a separate follow-up covering netif_trans_update.

In that follow-up (net-next material0, I can probably simplify
need_watchdog as well.

Thanks for the guidance,
--breno