Re: [PATCH] setlocalversion: make tag local to try_tag()

From: Nicolas Schier

Date: Tue Aug 25 2026 - 13:41:49 EST


On Sun, Aug 23, 2026 at 05:49:13PM +0800, Yuntao Wang wrote:
> The tag variable is only used by try_tag(), but is currently declared
> local to scm_version() and modified by try_tag().
>
> Make tag local to try_tag() instead and remove the unused declaration
> from scm_version().
>
> No functional changes.
>
> Signed-off-by: Yuntao Wang <yuntao.wang@xxxxxxxxx>
> ---
> scripts/setlocalversion | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Reviewed-by: Nicolas Schier <nsc@xxxxxxxxxx>

--
Nicolas