Re: [PATCH v3 2/5] iommu/amd: Fix DTE clearing and rename iommu_ignore_device()

From: Jason Gunthorpe

Date: Tue Aug 25 2026 - 13:53:48 EST


On Tue, Aug 25, 2026 at 05:29:59PM +0000, Pranjal Shrivastava wrote:

> I agree, but I wonder why the existing code used memset here
> (in ignore_device):
>
> memset(&dev_table[devid], 0, sizeof(struct dev_table_entry));
>
> I was thinking it might've been done for probe failures in a kdump
> kernel (normal kexec would've called shutdown for clearing all DTEs).
> (I see this was added long time back and existed when PCI segments were
> added [1]).

For kdump you'd want to keep the original translation running in this
case.

> Are you suggesting to remove the DTE clearing from this path entirely?

Yes

Jason