Re: [PATCH 3/7] rust: crc_ccitt: add CRC-CCITT abstraction
From: Eric Biggers
Date: Tue Aug 25 2026 - 13:58:54 EST
On Fri, Aug 21, 2026 at 10:55:41AM +0530, Ayush Singh wrote:
> > > diff --git a/rust/kernel/crc_ccitt.rs b/rust/kernel/crc_ccitt.rs
> > > new file mode 100644
> > > index 000000000000..6042ada16967
> > > --- /dev/null
> > > +++ b/rust/kernel/crc_ccitt.rs
> > Is there a reason why the kconfig symbol is being put in lib/crc/ but
> > the actual code is being put in rust/kernel/? It seems inconsistent.
> >
> > - Eric
>
>
> Was copying `RUST_SERIAL_DEV_BUS_ABSTRACTIONS`. It is also in
> `drivers/tty/serdev/Kconfig`.
kconfig options usually should be in the same directory as the code they
control.
- Eric