Re: [PATCH 1/6] mm/mglru: batch update lrugen->nr_pages in inc_min_seq()

[Barry Song]

On Sat, Aug 22, 2026 at 9:42 AM Lian Wang (ProcessMission)
<lianux.mm@xxxxxxxxx> wrote:
>
> From: Lian Wang <lianux.mm@xxxxxxxxx>
>
> Hi Barry,
>
> A small nit:
>
> > +             unsigned long delta = 0;
>
> lrugen->nr_pages is a signed long and is documented as being able to
> transiently go negative while reset_batch_size() is pending. Could delta
> remain a long as well, so this arithmetic stays signed?

Thanks, Lian, for the review. Changing it from unsigned long to long
makes sense to me.

>
> In 2/6, where the declarations are combined, this could be:
>
>         unsigned long protected[MAX_NR_TIERS] = {};
>         long delta = 0;
>

Best Regards
Barry