Re: [PATCH v1 3/3] iio: adc: bcm_iproc_adc: use devm-managed mutex initialization

[Marcelo Schmitt]

On 08/25, mdshahid03@xxxxxxxxx wrote:
> From: Mohammad Shahid <mdshahid03@xxxxxxxxx>
> 
> Use devm_mutex_init() to tie the mutex lifetime to the device and
> improve debugging when CONFIG_DEBUG_MUTEXES is enabled.
> 
> Signed-off-by: Mohammad Shahid <mdshahid03@xxxxxxxxx>
> ---
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx>

Though note the device driver currently lacks an include to mutex.h.

>  drivers/iio/adc/bcm_iproc_adc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c
> index 1464c60bc83e..9b299e2c3e0c 100644
> --- a/drivers/iio/adc/bcm_iproc_adc.c
> +++ b/drivers/iio/adc/bcm_iproc_adc.c
> @@ -530,7 +530,9 @@ static int iproc_adc_probe(struct platform_device *pdev)
>  	adc_priv = iio_priv(indio_dev);
>  	platform_set_drvdata(pdev, indio_dev);
>  
> -	mutex_init(&adc_priv->mutex);
> +	ret = devm_mutex_init(dev, &adc_priv->mutex);
> +	if (ret)
> +		return ret;
>  
>  	init_completion(&adc_priv->completion);