Re: [PATCH v13 RESEND 1/5] platform/x86: Sort firmware attributes class includes

[Tzung-Bi Shih]

On Mon, Aug 24, 2026 at 04:08:58PM +0100, Sean Rhodes wrote:
> Move firmware_attributes_class.h into the main include block and sort the
> affected includes. This lets the header move replace each include in place.
...
> diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> index 495dc1e31d40..f3d8c5a85762 100644
> --- a/drivers/platform/x86/asus-armoury.c
> +++ b/drivers/platform/x86/asus-armoury.c
> @@ -20,6 +20,7 @@
>  #include <linux/dmi.h>
>  #include <linux/err.h>
>  #include <linux/errno.h>
> +#include "firmware_attributes_class.h"
>  #include <linux/fs.h>
>  #include <linux/kernel.h>
>  #include <linux/kmod.h>

I don't really follow why it is beneficial to make the
firmware_attributes_class.h replacement in-place.  Moving relative includes
like "firmware_attributes_class.h" into the <linux/...> block creates an
awkward intermediate state.  How about drop patch 1 and simply update the
includes directly in patch 2?