Re: [PATCH] i2c: mv64xxx: fix autosuspend cleanup

[Guangshuo Li]

Hi Krzysztof,

On Thu, 20 Aug 2026 at 22:48, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 12/08/2026 10:58, Guangshuo Li wrote:
> > mv64xxx_i2c_probe() calls pm_runtime_use_autosuspend(), but the probe
> > failure and remove paths do not call the matching
> > pm_runtime_dont_use_autosuspend() before disabling runtime PM.
> >
> > If the autosuspend delay is set to a negative value while autosuspend
> > is enabled, the runtime PM core increments usage_count to prevent
> > runtime suspend. Without undoing the autosuspend setting during
> > teardown, this reference is not dropped and usage_count remains
> > unbalanced.
> >
> > Call pm_runtime_dont_use_autosuspend() in both the probe failure and
> > remove paths before disabling runtime PM to properly undo the
> > autosuspend setting.
> >
> > This issue was found by manual code inspection.
> >
> > Fixes: e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>
> > ---
> >  drivers/i2c/busses/i2c-mv64xxx.c | 2 ++
> >  1 file changed, 2 insertions(+)
>
> Srsly, one more separate I2C posting, just like you did for dma, crypto,
> drm and everywhere else. You seriously waste our time.
>
> You sent vast amount of patches, all separate, making it very difficult
> to track and respond in efficient way. Do not do that.
>
> Group your work per subsystem.
>
> You were asked to clarify and respond to incorrect fixes statement. I do
> not see how you clarified and responded at all.
>
> Best regards,
> Krzysztof

Sorry about that. I should have replied to the earlier review comments
explicitly, and I also should not have sent so many separate patches.

I will group future patches by subsystem and make sure to respond
clearly to review feedback before resending.

Thanks for pointing this out.

Best regards,
Guangshuo