[RFC PATCH v2 38/74] dtc: Change get_node_by_phandle() signature to take dt_info
From: Herve Codina
Date: Wed Aug 26 2026 - 06:07:59 EST
The future introduction of orphan nodes for addons device-tree will lead
to more than one tree in the addons data. Those trees will be:
- the classical root tree starting at the root node
- trees related to orphan nodes
Also, an addon device-tree can have only trees based on orphan nodes. In
other words an addon device-tree is valid without having the classical
'root' tree.
To prepare orphan nodes introduction, move get_node_by_phandle()
parameter one level up and use dt_info struct instead of the 'root' tree
(i.e. dti->dt).
This change doesn't lead to any functional changes.
Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>
---
checks.c | 14 +++++---------
dtc.h | 2 +-
livetree.c | 21 +++++++++++++++++----
treesource.c | 2 +-
4 files changed, 24 insertions(+), 15 deletions(-)
diff --git a/checks.c b/checks.c
index f4ae776b..6b25c204 100644
--- a/checks.c
+++ b/checks.c
@@ -541,7 +541,6 @@ static cell_t check_phandle_prop(struct check *c, struct dt_info *dti,
static void check_explicit_phandles(struct check *c, struct dt_info *dti,
struct node *node)
{
- struct node *root = dti->dt;
struct node *other;
cell_t phandle, linux_phandle;
@@ -563,7 +562,7 @@ static void check_explicit_phandles(struct check *c, struct dt_info *dti,
if (linux_phandle && !phandle)
phandle = linux_phandle;
- other = get_node_by_phandle(root, phandle);
+ other = get_node_by_phandle(dti, phandle);
if (other && (other != node)) {
FAIL(c, dti, node, "duplicated phandle 0x%x (seen before at %s)",
phandle, other->fullpath);
@@ -1422,7 +1421,6 @@ static void check_property_phandle_args(struct check *c,
struct property *prop,
const struct provider *provider)
{
- struct node *root = dti->dt;
unsigned int cell, cellsize = 0;
if (!is_multiple_of(prop->val.len, sizeof(cell_t))) {
@@ -1465,7 +1463,7 @@ static void check_property_phandle_args(struct check *c,
cell);
}
- provider_node = get_node_by_phandle(root, phandle);
+ provider_node = get_node_by_phandle(dti, phandle);
if (!provider_node) {
FAIL_PROP(c, dti, node, prop,
"Could not get phandle node for (cell %d)",
@@ -1632,7 +1630,6 @@ static void check_interrupt_map(struct check *c,
struct dt_info *dti,
struct node *node)
{
- struct node *root = dti->dt;
struct property *prop, *irq_map_prop;
size_t cellsize, cell, map_cells;
@@ -1686,7 +1683,7 @@ static void check_interrupt_map(struct check *c,
break;
}
- provider_node = get_node_by_phandle(root, phandle);
+ provider_node = get_node_by_phandle(dti, phandle);
if (!provider_node) {
FAIL_PROP(c, dti, node, irq_map_prop,
"Could not get phandle(%d) node for (cell %zu)",
@@ -1724,7 +1721,6 @@ static void check_interrupts_property(struct check *c,
struct dt_info *dti,
struct node *node)
{
- struct node *root = dti->dt;
struct node *irq_node = NULL, *parent = node;
struct property *irq_prop, *prop = NULL;
cell_t irq_cells, phandle;
@@ -1755,7 +1751,7 @@ static void check_interrupts_property(struct check *c,
continue;
}
- irq_node = get_node_by_phandle(root, phandle);
+ irq_node = get_node_by_phandle(dti, phandle);
if (!irq_node) {
FAIL_PROP(c, dti, parent, prop, "Bad phandle");
return;
@@ -1890,7 +1886,7 @@ static struct node *get_remote_endpoint(struct check *c, struct dt_info *dti,
if (!phandle_is_valid(phandle))
return NULL;
- node = get_node_by_phandle(dti->dt, phandle);
+ node = get_node_by_phandle(dti, phandle);
if (!node)
FAIL_PROP(c, dti, endpoint, prop, "graph phandle is not valid");
diff --git a/dtc.h b/dtc.h
index bf8f0ce4..27f49bc6 100644
--- a/dtc.h
+++ b/dtc.h
@@ -323,7 +323,6 @@ struct property *get_property_by_label(struct node *tree, const char *label,
struct marker *get_marker_label(struct node *tree, const char *label,
struct node **node, struct property **prop);
struct node *get_subnode(struct node *node, const char *nodename);
-struct node *get_node_by_phandle(struct node *tree, cell_t phandle);
struct node *get_node_by_ref(struct node *tree, const char *ref);
cell_t get_node_phandle(struct node *root, struct node *node);
@@ -357,6 +356,7 @@ struct dt_info {
struct node *get_node_by_path(struct dt_info *dti, const char *path);
struct node *get_node_by_label(struct dt_info *dti, const char *label);
+struct node *get_node_by_phandle(struct dt_info *dti, cell_t phandle);
/* DTS version flags definitions */
#define DTSF_V1 0x0001 /* /dts-v1/ */
diff --git a/livetree.c b/livetree.c
index aec1e160..5bd65b1b 100644
--- a/livetree.c
+++ b/livetree.c
@@ -584,7 +584,7 @@ static void complete_ref_and_is_local(struct dt_info *dti, char **ref,
}
if (*is_local) {
- refnode = get_node_by_phandle(dti->dt, phandle);
+ refnode = get_node_by_phandle(dti, phandle);
if (!refnode)
die("Node not found for phandle 0x%"PRIx32"\n", phandle);
@@ -834,7 +834,7 @@ static cell_t get_node_phandle_existing(struct node *node)
return propval_cell(prop);
}
-struct node *get_node_by_phandle(struct node *tree, cell_t phandle)
+static struct node *get_node_by_phandle_(struct node *tree, cell_t phandle)
{
struct node *child, *node;
cell_t tree_phandle;
@@ -852,7 +852,7 @@ struct node *get_node_by_phandle(struct node *tree, cell_t phandle)
}
for_each_child(tree, child) {
- node = get_node_by_phandle(child, phandle);
+ node = get_node_by_phandle_(child, phandle);
if (node)
return node;
}
@@ -918,6 +918,19 @@ struct node *get_node_by_label(struct dt_info *dti, const char *label)
return NULL;
}
+struct node *get_node_by_phandle(struct dt_info *dti, cell_t phandle)
+{
+ struct node *node;
+
+ if (dti->dt) {
+ node = get_node_by_phandle_(dti->dt, phandle);
+ if (node)
+ return node;
+ }
+
+ return NULL;
+}
+
static void add_phandle_property(struct node *node,
const char *name, int format)
{
@@ -941,7 +954,7 @@ cell_t get_node_phandle(struct node *root, struct node *node)
if (phandle_is_valid(node->phandle))
return node->phandle;
- while (get_node_by_phandle(root, phandle))
+ while (get_node_by_phandle_(root, phandle))
phandle++;
node->phandle = phandle;
diff --git a/treesource.c b/treesource.c
index d22f1d32..705fe9a6 100644
--- a/treesource.c
+++ b/treesource.c
@@ -205,7 +205,7 @@ void add_phandle_marker(struct dt_info *dti, struct property *prop, unsigned int
}
phandle = dtb_ld32(prop->val.val + offset);
- refn = get_node_by_phandle(dti->dt, phandle);
+ refn = get_node_by_phandle(dti, phandle);
if (!refn) {
if (quiet < 1)
--
2.55.0