Re: [PATCH v3 8/9] ASoC: qcom: Add Shikra QAIF support

[Srinivas Kandagatla]

On 8/26/26 9:58 AM, Harendra Gautam wrote:
>>> +             .id = QAIF_CDC_DMA_RX0,
>>> +             .name = "CDC DMA RX0",
>>> +             .playback = {
>>> +                     .stream_name = "WCD Playback0",
>>> +                     .formats = SNDRV_PCM_FMTBIT_S16,
>>> +                     .rates = SNDRV_PCM_RATE_48000,
>>> +                     .rate_min       = 48000,
>>> +                     .rate_max       = 48000,
>>> +                     .channels_min   = 1,
>>> +                     .channels_max   = 2,
>>> +             },
>>> +             .ops    = &asoc_qcom_qaif_cif_dai_ops,
>>> +     }, {
>>> +             .id = QAIF_CDC_DMA_RX1,
>>> +             .name = "CDC DMA RX1",
>>> +             .playback = {
>>> +                     .stream_name = "WCD Playback1",
>> No dai for WCD capture (or) it's missing in this patch.
>>
>>
>> Best Regards,
>> Rafi.
>>
> On Shikra, capture is always through the VA Macro, irrespective of
> whether the source is WCD AMIC or MSM DMIC and the stream_name is only
> a descriptive identifier.

WCD naming is totally incorrect w.r.t this driver, WCD is external
codec, which can be connected to any dai. QAIF just exposes FE dais It
should not have any codec level information either as names or any other.
Pl remove and use the correct naming which reflect the dai name w.r.t to
QAIF.

--srini

> -Harendra