Re: [PATCH 1/2] firmware: qcom: scm: Introduce new locking mechanism for SCM driver
From: Albert Esteve
Date: Wed Aug 26 2026 - 07:38:43 EST
On Tue, Aug 25, 2026 at 12:15 PM Konrad Dybcio
<konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
>
> On 8/24/26 1:35 PM, Albert Esteve wrote:
> > From: Ninad Naik <quic_ninanaik@xxxxxxxxxxx>
> >
> > With the existing global mutex lock, there is a possibility that it
> > could resulty into a deadlock when SMCInvoke and smc call go to
> > firmware in the same order and both wait on same WAITQ in firmware.
>
> I think the commit message should be extended to better explain how
> that may happen (because presumably it did in the real world)
>
> A Fixes tag may also be applicable here
Hi Konrad,
Sure, I will add more details for both this and the next patch in the
next version, along with the Fixes tag.
We triaged/ported the patches (see cover letter for their origin), but
I do not think we hit that specifically on our boards.
BR,
Albert
>
> Konrad
>