Re: [PATCH v6 00/10] dtc: dt-check-style: Improvements for false positives

[Rob Herring]

On Wed, Aug 26, 2026 at 01:15:52PM +0200, Krzysztof Kozlowski wrote:
> This might be a frequent posting, because Sashiko finds a lot of border
> cases.  It turns out parsing text is not that easy (surprise!).
> 
> Changes in v6:
> - Handle white-space differences in overlays '&{/} {' part
> - Bring back strip() from _strip_strings_and_comments() rework
> - Minor commit msg improvements
> - Link to v5: https://patch.msgid.link/20260826-n-dts-style-checker-continued-v5-0-fdd16ca6e771@xxxxxxxxxxxxxxxx
> 
> Changes in v5:
> - Patch #3: Trailing whitespace or comments break multi-line property alignment validation
> - Patch #9: The regular expression `r'(\s\s+|\t){'` uses an unescaped `{`
>             The redundant whitespace checks do not validate continuation lines of multi-line properties
> - More tests for each of cases brought by Sashiko
> - Link to v4: https://patch.msgid.link/20260826-n-dts-style-checker-continued-v4-0-022e60091965@xxxxxxxxxxxxxxxx
> 
> Changes in v4:
> - First two patches merged
> - Squashed previous #3 into next one (#4... but now it is patch #1),
>   because: detection of root is still needed for DTS/DTSO with code:
>   &soc {
> 	children ...
>   };
>   where comparing the c.parent.node_name to None or / would give false
>   results of being child of root node.
>   Fix regex pattern for "/{" case.
> - Fix comments from Sashiko (rebasing issue, help msg, align continued
>   values based on previous one ending with ',', do not report whitespace
>   issues for comments)
> - More test fixtures
> - New patches:
>   dtc: dt-check-style: Replace Test User email with Rob Herring
>   dtc: dt-check-style: Call _strip_strings_and_comments() only once
> - Link to v3: https://patch.msgid.link/20260803-n-dts-style-checker-continued-v3-0-6c9776928cea@xxxxxxxxxxxxxxxx
> 
> Changes in v3:
> - Responded to Sashiko and implemented its comments
> - Properly handle root node with more than one space "/  {"
> - Add more unit tests for DTSO whether properties and nodes are properly
>   detected as top-level
> - Link to v2: https://patch.msgid.link/20260802-n-dts-style-checker-continued-v2-0-6c5dbd1ccfe4@xxxxxxxxxxxxxxxx
> 
> Changes in v2:
> - Trailing slash to maintainers path
> - New patches:
>    - Patch #9: dtc: dt-check-style: Add test for trailing white-space in DTS
>    - Patch #10: dtc: dt-check-style: Add warning for redundant white-spaces
> - Several fixes based on Sashiko's report (I responded to these on the
>   lists)
>    - _walk_bodies(): Fix setting up proper parent to each node after
>      exiting node parsing. This wasn't working correctly.
>    - check_child_name_order(): Properly sort top-level nodes by names,
>      even if it comes with unit address like memory@1000
>    - Add rest of property_bucket sorting for top-level properties,
>      even though no properties are expected there, except few vendor
>      ones
>    - check_continuation_alignment(): Improve error msg for
>      continuned-lines alignment warnings
> 
> - Link to v1: https://patch.msgid.link/20260726-n-dts-style-checker-continued-v1-0-b05b8f897670@xxxxxxxxxxxxxxxx
> 
> Few improvements and proper handling of top-level node (name, not unit
> address sorting) and property (model before compatible) sorting.
> 
> Best regards,
> Krzysztof
> 
> ---
> Krzysztof Kozlowski (10):
>       dtc: dt-check-style: Handle sorting of top-level nodes and properties
>       dtc: dt-check-style: Drop stray backslash before quote for continuation-alignment
>       dtc: dt-check-style: Fix alignment of values in continued property lines
>       dtc: dt-check-style: Consistently call 'kind' as 'file_type'
>       dtc: dt-check-style: Introduce 'stricter' mode
>       dtc: dt-check-style: Replace Test User email with Rob Herring
>       dtc: dt-check-style: Call _strip_strings_and_comments() only once
>       dtc: dt-check-style: Add test for trailing white-space in DTS
>       dtc: dt-check-style: Add warning for redundant white-spaces
>       MAINTAINERS: dt-bindings: Include dt-check-style in DT binding entry

The remaining sashiko issues look unlikely to me, so I applied the 
series.

Rob