RE: [PATCH 4/7] platform/x86/intel/bff: Add Diamond Rapids support

[Luck, Tony]

Hi Ilpo.

Thanks for reviewing.

> > +/* Machine check bank scope types */
> > +enum bff_type {
> > +   BFF_NONE = 0,
> > +   BFF_BANK_DCU,
> > +   BFF_BANK_DTLB,
> > +   BFF_BANK_MLC,
> > +   BFF_BANK_CCF,
> > +   BFF_BANK_HSF,
> > +   BFF_BANK_IOCACHE,
> > +};

Trailing comma here because this enum will expand when additional CPUs are supported that
have different types of banks that support the bitfix filter.

> > +
> > +static const enum bff_type dmr_mcbanks[MAX_NR_BANKS] = {
> > +   [1]     = BFF_BANK_DCU,
> > +   [2]     = BFF_BANK_DTLB,
> > +   [3]     = BFF_BANK_MLC,
> > +   [6]     = BFF_BANK_CCF,
> > +   [13]    = BFF_BANK_HSF,
> > +   [17]    = BFF_BANK_IOCACHE
>
> Please add trailing comma.

No trailing comma here because this list is complete. Diamond rapids will not suddenly add a new bitfix filter attached to a bank numbered > 17.

-Tony