Re: [PATCH 2/2] gpu: nova-core: use kernel lossless integer conversion module
From: Alexandre Courbot
Date: Wed Aug 26 2026 - 21:36:24 EST
On Tue Aug 25, 2026 at 2:27 PM JST, Eliot Courtney wrote:
> On Tue Aug 25, 2026 at 11:44 AM JST, Alexandre Courbot wrote:
>> The `kernel` crate now features a replacement for our lossless integer
>> conversion routines. Switch to the kernel version and remove our own.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
>> ---
>
> nit: casts:: prefix feels noisy to me in actual usages - just import
> const_as!, etc and use them directly?
Yup, I used the prefix to keep the import list short because we were
calling various `*_as_*` and `*_into_*` methods in some modules, but
since we can convert all of them to either `FromSafeCast` or `const_as`,
this is much more manageable so we'll be able to drop it.