Re: [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m

From: Andrew Morton

Date: Wed Aug 26 2026 - 23:51:10 EST


On Mon, 24 Aug 2026 17:14:01 +0200 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:

> Enabling the (possibly long-running benchmarks) by default may cause a
> big delay in boot time in case of built-in tests. However, they can
> still safely be enabled by default if all tests are modular, as they
> would only run when requested explicitly by the system administrator.
>
> ...
>
> --- a/lib/raid/Kconfig
> +++ b/lib/raid/Kconfig
> @@ -32,6 +32,7 @@ config XOR_KUNIT_TEST
> config XOR_BENCHMARK
> bool "Benchmark for xor_gen"
> depends on XOR_KUNIT_TEST
> + default y if KUNIT_ALL_TESTS=m
> help
> Include benchmarks in the KUnit test suite for xor_gen.
>
> @@ -63,6 +64,7 @@ config RAID6_PQ_KUNIT_TEST
> config RAID6_PQ_KUNIT_BENCHMARK
> bool "Benchmark for RAID6 PQ"
> depends on RAID6_PQ_KUNIT_TEST
> + default y if KUNIT_ALL_TESTS=m
> help
> Include benchmarks in the KUnit test suite for raid P/Q generation.

OK, thanks, but...

hp2:/usr/src/mm> scripts/get_maintainer.pl -f --no-rolestats lib/raid
[not linux-raid@xxxxxxxxxxxxxxx]

Patches enthusiastically accepted ;)