Re: [PATCH v2] ppc/fadump: collect dump if the collected size is lesser than reserved

[Shivang Upadhyay]

On Thu, 2026-08-27 at 11:05 +0530, Sourabh Jain wrote:
> 
> > bytes_dumped <= source_len));
> 
> Do we really need region_collected variable? Can't we manage with rc
> only?
> 
> Is bytes_dumped < source_len is good enough instead of <=. There are
> a 
> couple of warnings/errors reported by the checkpatch script.
> Please address them in the next version.
> 
> - Sourabh Jain
> 
Hi Sourabh, 

bytes_dumped < source_len should also be correct, but "<=" is more
expressive. Why not leave such optimizations to compiler.

For the region_collected, RC should be used to manage the return code,
so I as per me it is more appropriate to use new variable here. Or
maybe, type the condition in the bracket itself(?).

Thanks for pointing out the checkpatch bugs, I'll send a revision soon.

~Shivang.