RE: [PATCH v16 2/8] i3c: master: Add controller-only device operation helpers

[Lakshay Piplani]

Hi Frank,

Thanks for the review.

> > +/**
> > + * i3c_dev_recycle_ibi_slot_controller() - Recycle an IBI slot through
> > + *                                    the current controller
> > + * @dev: I3C device descriptor
> > + * @slot: IBI slot to recycle
> > + *
> > + * Invoke the current controller's IBI slot recycling callback.
> > + *
> > + * The controller is responsible for synchronizing access to its IBI pool.
> > + */
> > +void i3c_dev_recycle_ibi_slot_controller(struct i3c_dev_desc *dev,
> > +                                    struct i3c_ibi_slot *slot)
>
> does this one need hold lock?
>
> Frank

No. It's called from i3c_master_handle_ibi() in workqueue context and just forwards to ops->recycle_ibi_slot(); the controller synchronizes its own pool (generic pool uses its own spinlock).  I'll document the calling context.

Thanks
Lakshay




NXP Confidential