Re: [PATCH v8 2/6] platform/x86: int3472: tps68470: use unsigned int for GPIO lookup loop counters
From: Andy Shevchenko
Date: Thu Aug 27 2026 - 03:18:57 EST
On Wed, Aug 26, 2026 at 01:24:47PM +0200, Thierry Chatard wrote:
> The GPIO lookup table loops in the probe and remove paths iterate up to
> board_data->n_gpiod_lookups, which is unsigned int. Use unsigned int for
> the loop counters to match and avoid a signed/unsigned comparison.
>
> No functional change.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
See one nit-pick below.
...
> static int skl_int3472_tps68470_probe(struct i2c_client *client)
> int n_consumers;
> int device_type;
> int ret;
> - int i;
> + unsigned int i;
Please, preserve reversed xmas tree order
int n_consumers;
int device_type;
unsigned int i;
int ret;
--
With Best Regards,
Andy Shevchenko