Re: [PATCH v3 5/9] dt-bindings: usb: dwc3: Document ST STM32MP2 DWC3 xHCI USB controller

From: Krzysztof Kozlowski

Date: Thu Aug 27 2026 - 09:06:41 EST


On Sat, Aug 22, 2026 at 09:46:38AM +0200, Marek Vasut wrote:
> The ST STM32MP2 SoC contains single instance of DWC3 USB controller with
> glue logic wrapper around it controlled by syscon. Document the glue
> logic and DWC3 controller.
>
> Co-developed-by: Pankaj Dev <pankaj.dev@xxxxxx>
> Signed-off-by: Pankaj Dev <pankaj.dev@xxxxxx>
> Co-developed-by: Clément Le Goffic <clement.legoffic@xxxxxxxxxxx>
> Signed-off-by: Clément Le Goffic <clement.legoffic@xxxxxxxxxxx>
> Co-developed-by: Gatien Chevallier <gatien.chevallier@xxxxxxxxxxx>
> Signed-off-by: Gatien Chevallier <gatien.chevallier@xxxxxxxxxxx>
> Signed-off-by: Marek Vasut <marex@xxxxxxxxxxxx>
> ---
> Cc: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>
> Cc: Christian Bruel <christian.bruel@xxxxxxxxxxx>
> Cc: Conor Dooley <conor+dt@xxxxxxxxxx>
> Cc: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
> Cc: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> Cc: Pankaj Dev <pankaj.dev@xxxxxx>
> Cc: Rahul Kumar <rahul.kumar05@xxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Cc: Rosen Penev <rosenp@xxxxxxxxx>
> Cc: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>
> Cc: Vinod Koul <vkoul@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: kernel@xxxxxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-phy@xxxxxxxxxxxxxxxxxxx
> Cc: linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Cc: linux-usb@xxxxxxxxxxxxxxx
> ---
> V2: Fix up Sob/Cdb lines
> V3: - Document maximum-speed
> - Switch resets to maxItems: 1
> - Drop label from example
> - Use generic over-current-active-low
> - Use ref: snps,dwc3-common.yaml and drop generic dr_mode/maximum-speed/phys/phy-names
> ---
> .../bindings/usb/st,stm32mp25-dwc3.yaml | 97 +++++++++++++++++++
> 1 file changed, 97 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/st,stm32mp25-dwc3.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/st,stm32mp25-dwc3.yaml b/Documentation/devicetree/bindings/usb/st,stm32mp25-dwc3.yaml
> new file mode 100644
> index 0000000000000..96bd557327252
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/st,stm32mp25-dwc3.yaml
> @@ -0,0 +1,97 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/st,stm32mp25-dwc3.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STM32 MPU DWC3 USB SoC controller
> +
> +description:
> + The STM32 MPU DWC3 USB SoC controller block supports both
> + Host(SS/HS/FS/LS) and Device(SS/HS/FS) mode operation
> +
> +maintainers:
> + - Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>
> + - Marek Vasut <marex@xxxxxxxxxxxx>
> +
> +allOf:
> + - $ref: snps,dwc3-common.yaml#

Honestly, I am lost. It seems this resolves my comment at v2, but now I
went through patchset from Fabrice Gasnier which was ON TOP of this
patch adding this line.

It is not your fault, although if there are pending comments expressed
not via review but via patchses on top of things being reviewed, then
can you check for them?

Best regards,
Krzysztof