Re: [PATCH v4 1/2] ASoC: Intel: Add Cherry Trail RT5677 machine driver

[Mark Brown]

On Thu, Aug 27, 2026 at 09:25:16AM +0200, Maurizio Casciano wrote:

> Link: https://github.com/jekhor/yogabook-linux-kernel/commit/4e41d0ff72c1d1fd8d5c59dda247e4ca8a1da999
> 
> Link: https://lore.kernel.org/linux-sound/20260611-asoc-yogabook-v2-v3-3-3128447b67b6@xxxxxxxxx/
> 
> Signed-off-by: Maurizio Casciano <mauriziocasciano7@xxxxxxxxx>
> 
> Assisted-by: Codex:gpt-5.6-sol sparse

This isn't how trailers should be formatted, please look at other
commits for examples.

> +static int cht_rt5677_codec_fixup(struct snd_soc_pcm_runtime *rtd,
> +				  struct snd_pcm_hw_params *params)
> +{

> +	/*
> +	 * Configure SSP2 for the 24-bit format expected by the codec. The SST
> +	 * ssp2-port front end still advertises S16_LE and converts the stream.
> +	 */
> +	params_set_format(params, SNDRV_PCM_FORMAT_S24_LE);

params_set_format() is addative, it won't clear any existing format that
was set which is not what you're looking for here.

Attachment: signature.asc
Description: PGP signature