Re: [PATCH v4 2/7] watchdog: mediatek: Add wdt/toprgu resets for mt6589

[Krzysztof Kozlowski]

On 27/08/2026 16:28, Luca Leonardo Scorcia wrote:
>>>  drivers/watchdog/mtk_wdt.c | 7 ++++++-
>>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
>>> index 91d110646e16..f8208fb0f723 100644
>>> --- a/drivers/watchdog/mtk_wdt.c
>>> +++ b/drivers/watchdog/mtk_wdt.c
>>> @@ -10,6 +10,7 @@
>>>   */
>>>
>>>  #include <dt-bindings/reset/mt2712-resets.h>
>>> +#include <dt-bindings/reset/mediatek,mt6589-wdt.h>
>>
>> I do not see how you use the bindings here, so my previous comments
>> stay. You just ignored it and never replied. In such case:
>>
>> NAK
> 
> The mtk_wdt driver requires the total number of available resets to
> register the reset controller. This was defined as
> MT6589_TOPRGU_SW_RST_NUM in the binding header, therefore the need for
> including it.

Number of signals almost never a binding. How do you even use it in DTS?

Best regards,
Krzysztof