Re: [PATCH v3 07/15] interconnect: qcom: Add Kuno interconnect provider driver

[Hardeep Sharma]

On 8/24/2026 1:27 PM, Abel Vesa wrote:
> On 26-08-21 21:39:00, Hardeep Sharma wrote:
> > Add the interconnect provider driver for the Qualcomm Kuno SoC to
> > enable bus bandwidth voting on the platform. This includes the
> > aggre-noc and cnoc-main NoC instances with their associated BCM
> > nodes.
> >
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Hardeep Sharma <hardeep.sharma@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/interconnect/qcom/Kconfig  |  13 +
> >   drivers/interconnect/qcom/Makefile |   2 +
> >   drivers/interconnect/qcom/kuno.c   | 977 +++++++++++++++++++++++++++++++++++++
> >   3 files changed, 992 insertions(+)
> [...]
>
> > diff --git a/drivers/interconnect/qcom/kuno.c b/drivers/interconnect/qcom/kuno.c
> > new file mode 100644
> > index 000000000000..9a5bd53e7ed9
> > --- /dev/null
> > +++ b/drivers/interconnect/qcom/kuno.c
> > @@ -0,0 +1,977 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> > + */
> [...]
>
> > +static const struct of_device_id qnoc_of_match[] = {
> > +	{ .compatible = "qcom,kuno-aggre-noc", .data = &kuno_aggre_noc },
> > +	{ .compatible = "qcom,kuno-clk-virt", .data = &kuno_clk_virt },
> > +	{ .compatible = "qcom,kuno-cnoc-main", .data = &kuno_cnoc_main },
> > +	{ .compatible = "qcom,kuno-dc-noc", .data = &kuno_dc_noc },
> > +	{ .compatible = "qcom,kuno-mc-virt", .data = &kuno_mc_virt },
> > +	{ .compatible = "qcom,kuno-mem-noc", .data = &kuno_mem_noc },
> > +	{ .compatible = "qcom,kuno-pcie-anoc", .data = &kuno_pcie_anoc },
> > +	{ .compatible = "qcom,kuno-system-noc", .data = &kuno_system_noc },
> > +	{ }
> > +};
> > +MODULE_DEVICE_TABLE(of, qnoc_of_match);
> > +
> > +static struct platform_driver qnoc_driver = {
> > +	.probe = qcom_icc_rpmh_probe,
> > +	.remove = qcom_icc_rpmh_remove,
> > +	.driver = {
> > +		.name = "qnoc-kuno",
> > +		.of_match_table = qnoc_of_match,
> > +		.sync_state = icc_sync_state,
> > +	},
> > +};
> qnoc_driver_init() and core_initcall()
>
> then
>
> qnoc_driver_exit() and module_exit()
>
> Please have a look at all other Qualcomm interconnect drivers in upstream.

Thanks for review.

Corrected in v4 : 
https://lore.kernel.org/all/20260827-kuno-soc-support-v4-0-dd34f235fc1a@xxxxxxxxxxxxxxxx/

Best Wishes
Hardeep Sharma