Re: [PATCH net v2 1/2] net: dsa: mt7530: populate lpi_interfaces to fix EEE support

[Andrew Lunn]

On Mon, Aug 24, 2026 at 05:41:16AM +0300, Aleksei Sviridkin wrote:
> mt753x_phylink_get_caps() fills in lpi_capabilities and
> lpi_timer_default but never lpi_interfaces, so phylink treats the MAC
> as not supporting EEE: ethtool reports "Not supported" and
> phy_disable_eee() keeps userspace locked out. That undoes what
> commit 06dfcd4098cf ("net: dsa: mt7530: fix enabling EEE on MT7531
> switch on all boards") arranged: EEE off by default, but enableable
> with ethtool.
> 
> Copy the supported interfaces into lpi_interfaces after
> mac_port_get_caps() has populated them, and leave the speeds above
> 1 Gbps out for now: drop 2500BASE-X from the copy, drop MAC_2500FD

Blah, blah, blah.

Please assume i can read the patch and understand what it does.

The commit message is about answering the question "Why?". That you
often cannot see from the code.

    Andrew

---
pw-bot: cr