Re: [PATCH 02/11] accel: ethosu: Drop IRQF_SHARED flag

From: Frank Li

Date: Thu Aug 27 2026 - 16:49:17 EST


On Thu, Aug 27, 2026 at 03:33:01PM -0500, Rob Herring (Arm) wrote:
> The IRQF_SHARED flag doesn't work with runtime-pm as the IRQ handler
> could run without resuming the device. This could also be fixed with
> runtime-pm calls in the IRQ handler, but there is no known need for a
> shared IRQ.
>
> Fixes: 5a5e9c0228e6 ("accel: Add Arm Ethos-U NPU driver")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> ---

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

> drivers/accel/ethosu/ethosu_job.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/ethosu/ethosu_job.c b/drivers/accel/ethosu/ethosu_job.c
> index 99c8812691e5..c33f2877b385 100644
> --- a/drivers/accel/ethosu/ethosu_job.c
> +++ b/drivers/accel/ethosu/ethosu_job.c
> @@ -337,7 +337,7 @@ int ethosu_job_init(struct ethosu_device *edev)
> ret = devm_request_threaded_irq(dev, edev->irq,
> ethosu_job_irq_handler,
> ethosu_job_irq_handler_thread,
> - IRQF_SHARED, KBUILD_MODNAME,
> + 0, KBUILD_MODNAME,
> edev);
> if (ret) {
> dev_err(dev, "failed to request irq\n");
>
> --
> 2.53.0
>