Re: [PATCH v2] iio: core: Replace BUG() with WARN_ON_ONCE() and error return

[Rishab M]

Thanks for the feedback.  I totally understand the perspective on code churn
versus making tree wide cleanups, and I will let Jonathan make the final call
on whether this is suitable.  I've also noted the wrapping width feedback for
commit messages in the future.

Best,
Rishab

On Wed, Aug 26, 2026 at 11:41 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> On Wed, Aug 26, 2026 at 09:31:40PM +0000, Rishab Madhugiri wrote:
> > As documented in Documentation/process/deprecated.rst, the
> > use of BUG() and BUG_ON() should be avoided as they could
> > cause a complete system crash, preventing further debugging.
>
> Right, but deprecation doesn't mean the _old_ existing code must be immediately
> changed. I leave it to Jonathan, but I see no value in this change except
> the unneeded churn. If we ever want to drop BUG(), it should be done tree wide.
> Hence no tag given.
>
> > In iio_get_time_ns() and current_timestamp_clock_show(), the
> > clock type is already validated against supported clock
> > types prior to these calls, making the default switch
> > branches expected to be unreachable. Replace these with
> > WARN_ON_ONCE(1) followed by an error return to avoid a
> > crash and to log the highly unexpected condition.
>
> There is like 10+ character space on each line, the commit message shouldn't
> be that condensed.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>