Re: [RFC PATCH v5 3/3] iio: position: add Rust driver for ams AS5600

[Muchamad Coirul Anwar]

Hi Jonathan,

Thanks.

On Mon, 24 Aug 2026 at 07:17, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> > The AS5600 stores the 12-bit raw angle big-endian across registers
> > 0x0C-0x0D. smbus_read_word_swapped() handles the byte swap: SMBus
> > always transmits the low byte first (little-endian wire), so an
> > unconditional byte swap recovers the correct value regardless of CPU
> > endianness. The long-term solution is regmap-rs where endianness is
> > configured once at the transport level.
> >
> > This driver uses INDIO_DIRECT_MODE without buffer or trigger support.
>
> I'd only talk about what you do support.  There are always many things
> that aren't in an initial driver so listing that bit doesn't provide much
> value.

Yes, I'll remove that sentence.

> >
> > Tested on BeagleBone Black (AM335x) with AS5600 on i2c-2 (0x36).
>
> Generally put things like testing info in the cover letter or below
> the ---

I'll move it below the --- separator.

> The code itself looks fine to me - but as with earlier I'm looking
> for rust expert review.


I'll add an explicit review request to Danilo, Igor, and Brandon in
the v6 cover letter.

Thanks again for making time to review.

Coirul