Re: [PATCH net-next 2/4] net: macb: Move TC capability and PM checks to macb_setup_tc()

[Théo Lebrun]

Hello Vineeth,

On Fri Aug 7, 2026 at 11:50 AM CEST, Vineeth Karumanchi wrote:
> Move the NETIF_F_HW_TC capability check and the runtime PM suspend
> guard from macb_setup_taprio() into the common macb_setup_tc()
> entry point.
>
> These preconditions apply to all hardware TC offload paths routed
> through ndo_setup_tc(), not just TAPRIO. Centralizing them avoids
> duplicating the same checks as new TC qdisc types are added.
>
> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@xxxxxxx>

Makes sense

Reviewed-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com