[PATCH 2/2] platform/x86: asus-armoury: fix pending_reboot for grouped attributes
From: Ahmed Yaseen
Date: Fri Aug 28 2026 - 07:13:28 EST
asus_bios_requires_reboot() matches attr->attr.name against
"gpu_mux_mode" and "panel_hd_mode", but callers hand it a current_value
attribute, and that name is always "current_value". The match never
hits, so panel_hd_mode never sets pending_reboot or emits the
KOBJ_CHANGE uevent. gpu_mux_mode gets away with it because its
hand-written store signals the event itself.
Match on the group name instead, which armoury_attr_uint_store() now
has at hand.
Fixes: f99eb098090e ("platform/x86: asus-armoury: move existing tunings to asus-armoury module")
Signed-off-by: Ahmed Yaseen <yaseen@xxxxxxxxx>
---
drivers/platform/x86/asus-armoury.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
index 8e85fb08bd59..23aabc827e39 100644
--- a/drivers/platform/x86/asus-armoury.c
+++ b/drivers/platform/x86/asus-armoury.c
@@ -128,10 +128,10 @@ static ssize_t pending_reboot_show(struct kobject *kobj, struct kobj_attribute *
static struct kobj_attribute pending_reboot = __ATTR_RO(pending_reboot);
-static bool asus_bios_requires_reboot(struct kobj_attribute *attr)
+static bool asus_bios_requires_reboot(const char *fsname)
{
- return !strcmp(attr->attr.name, "gpu_mux_mode") ||
- !strcmp(attr->attr.name, "panel_hd_mode");
+ return !strcmp(fsname, "gpu_mux_mode") ||
+ !strcmp(fsname, "panel_hd_mode");
}
/**
@@ -315,7 +315,7 @@ ssize_t armoury_attr_uint_store(struct kobject *kobj, struct kobj_attribute *att
*store_value = value;
sysfs_notify(kobj, fsname, attr->attr.name);
- if (asus_bios_requires_reboot(attr))
+ if (asus_bios_requires_reboot(fsname))
asus_set_reboot_and_signal_event();
return count;
--
2.55.0