Re: [PATCH v8 1/6] dt-bindings: spmi: apple,spmi: Add t603x and t8122

[Conor Dooley]

On Fri, Aug 28, 2026 at 10:58:57AM +0200, Sasha Finkelstein wrote:
> Add t603x and t8122 compatibles, interrupt support, and support for
> SPMI controllers that are not always-on.
> 
> Reviewed-by: Janne Grunau <j@xxxxxxxxxx>
> Signed-off-by: Sasha Finkelstein <k@xxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/spmi/apple,spmi.yaml | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spmi/apple,spmi.yaml b/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> index 3e5b14bc8c31..09d383bb4fec 100644
> --- a/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> +++ b/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> @@ -20,8 +20,11 @@ properties:
>        - items:
>            - enum:
>                - apple,t6020-spmi
> +              - apple,t6030-spmi
> +              - apple,t6031-spmi
>                - apple,t8012-spmi
>                - apple,t8015-spmi
> +              - apple,t8122-spmi
>            - const: apple,t8103-spmi
>        - items:
>            - enum:
> @@ -34,10 +37,38 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  interrupts:
> +    maxItems: 1
> +    description: Optional, operates in polled mode if not present
> +
> +  interrupt-controller: true
> +
> +  "#interrupt-cells":
> +    const: 2
> +
> +  power-domains:
> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
>  
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - apple,t8122-spmi
> +          - apple,t6030-spmi
> +          - apple,t6031-spmi
> +then:
> +  required:
> +    - compatible
> +    - reg

This duplicates the unconditional required bit, I would drop it so that
you can add an else condition and rule out the interrupt related stuff
on the devices where it may not apply?
Even if the itnerrupt stuff is possible elsewhere, please drop the
duplicated part.

Thanks,
Conor.
pw-bot: changes-requested

> +    - interrupt-controller
> +    - "#interrupt-cells"
> +    - interrupts
> +
>  unevaluatedProperties: false
>  
>  examples:
> 
> -- 
> 2.55.0
>

Attachment: signature.asc
Description: PGP signature