Re: [PATCH v8 2/3] arm64: dts: qcom: kodiak: enable inline crypto engine for SDHC

[Konrad Dybcio]

On 8/28/26 2:57 PM, Abel Vesa wrote:
> On 26-06-30 13:25:13, Konrad Dybcio wrote:
>> On 6/30/26 12:23 PM, Kuldeep Singh wrote:
>>>> qcom_ice_probe()
>>>>   -> qcom_ice_create()
>>>>     -> devm_clk_get_optional_enabled()

[...]

>> On the developer/customer experience side, would you expect having to
>> manually enable what's essentially a sub-feature of the storage media
>> on every single board?
> 
> Wait, don't we do that for display nodes anyway ?
> 
> Also there might be a case where you just don't want the ICE enabled.

I can think of literally none..

> So I suggest we disable the ICE by default and enable it only on boards
> where there is a consumer.
> 
> We don't normally leave stuff enabled just because runtime PM will
> disabled it for us.

We should because the hardware is in a state that's otherwise unknown
to Linux, I've been trying to push that forward, but many things
currently can't be enabled without side effects.

With the right drivers in place, the hw can be safely powered off or
at least parked, instead of letting it spin in whatever state the
bootloader has left it in.

Konrad