Re: [PATCH] thermal/drivers/qcom/spmi-mbg-tm: Import IIO_CONSUMER namespace

[Jonathan Cameron]

On Thu, 27 Aug 2026 22:35:27 +0800
Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx> wrote:

> On Thu, Aug 27, 2026 at 03:52:42PM +0300, Andy Shevchenko wrote:
> > On Thu, Aug 27, 2026 at 06:35:55PM +0800, Shawn Guo wrote:  
> > > The IIO consumer interface symbols moved into the IIO_CONSUMER namespace,
> > > so consumers must import it explicitly.  Without it modpost fails on  
> >   
> > > 'iio_read_channel_processed' and 'devm_iio_channel_get':  
> > 
> > iio_read_channel_processed()
> > devm_iio_channel_get()  
> 
> Sure, will update.
> 
> >   
> > >   ERROR: modpost: drivers/thermal/qcom/qcom-spmi-mbg-tm.ko: module uses
> > >   symbol 'iio_read_channel_processed' from namespace 'IIO_CONSUMER', but
> > >   does not import it.  
> >   
> > > Fixes: ebf1d03dab96 ("iio: inkern: Use namespaced exports")  
> > 
> > Shouldn't this be backported to stable kernels?  
> 
> The offending commit just landed on mainline during this merge window.
> So there is no stable kernels concerned by this.

There is a fix on the thermal tree. I though that was enough. Maybe this
races with that fix going upstream?

Jonathan

> 
> > 
> > ...
> > 
> > Code wise looks good.  
> 
> Thank you for the review!
> 
> Shawn