Re: [PATCH v9 03/11] x86/virt/tdx: Add tdx_alloc/free_control_page() helpers

From: Vishal Annapurve

Date: Fri Aug 28 2026 - 18:54:56 EST


On Fri, Aug 28, 2026 at 3:23 PM Edgecombe, Rick P
<rick.p.edgecombe@xxxxxxxxx> wrote:
>
> On Fri, 2026-08-28 at 12:50 -0700, Vishal Annapurve wrote:
> > Reviewed-by: Vishal Annapurve <vannapurve@xxxxxxxxxx> for the
> > SEAMCALLs and the get/put helpers, assuming your are still thinking to
> > shift things a bit between the current and the next patch.
>
> I looked at moving tdx_alloc/free_control_page() to the next patch. But Dave's
> comment was more along the lines of just commenting the limitations. So rather
> than disturb the already reviewed patches at this point, I'm just commented the
> limitations clearly. And then removing the comments when the limitations are
> fixed.
>
> So the only only code change here is temporarily prepending the limited
> functions with __.

Sounds good.

>
> Do you want to keep your RBs?

Yeah.

>
> Rick