Re: [PATCH v2 09/11] iio: temperature: tsys01: make headers conform to IWYU

[Jonathan Cameron]

> Remove the catch-all kernel.h header, add missing headers and remove

Seems some fixups in wrong patch as tmp117 stuff in here.

Sashiko shouted about that.

> unused headers.
> 
> Signed-off-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
>
> diff --git a/drivers/iio/temperature/tmp117.c b/drivers/iio/temperature/tmp117.c
> index 25bc98e64e48..96252627613f 100644
> --- a/drivers/iio/temperature/tmp117.c
> +++ b/drivers/iio/temperature/tmp117.c
> @@ -12,13 +12,12 @@
>  #include <linux/array_size.h>
>  #include <linux/bitops.h>
>  #include <linux/delay.h>
> -#include <linux/dev_printk.h>
> +#include <linux/device.h>
>  #include <linux/err.h>
>  #include <linux/i2c.h>
>  #include <linux/limits.h>
>  #include <linux/minmax.h>
>  #include <linux/module.h>
> -#include <linux/property.h>
>  #include <linux/regulator/consumer.h>
>  #include <linux/types.h>
>  
> diff --git a/drivers/iio/temperature/tsys01.c b/drivers/iio/temperature/tsys01.c
> index 14de67ee8be7..3c1f5b6ac156 100644
> --- a/drivers/iio/temperature/tsys01.c
> +++ b/drivers/iio/temperature/tsys01.c
> @@ -8,12 +8,14 @@
>   *  http://www.meas-spec.com/downloads/TSYS01_Digital_Temperature_Sensor.pdf
>   */
>  
> -#include <linux/device.h>

 | sashiko.dev <sashiko@xxxxxxxxxxx>:
 |
 | [Severity: Low]
 | Does removing <linux/device.h> contradict the Include What You Use principles
 | mentioned in the commit message?
 |
 | Looking at tsys01_probe(), it directly dereferences struct device and struct
 | device_driver:
 |
 | tsys01_probe() {
 |     ...
 |     indio_dev->name = dev->driver->name;

Looks valid to me.

 |     ...
 | }

Jonathan

-- 
Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>