Re: [PATCH v4 1/4] fs: fix missed removal of super_fs_objects_eligible()

[Andrew Morton]

On Sat, 29 Aug 2026 09:49:44 +0800 Qi Zheng <qi.zheng@xxxxxxxxx> wrote:

> Hi Andrew,
> 
> On 8/29/26 2:41 AM, Andrew Morton wrote:
> > On Mon, 17 Aug 2026 17:03:25 +0800 Qi Zheng <qi.zheng@xxxxxxxxx> wrote:
> > 
> >> From: Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx>
> >>
> >> Commit 0ef8faff490be ("fs: push nr_cached_objects memcg gating into
> >> individual filesystems") forgot to drop the super_fs_objects_eligible(),
> >> just fix it.
> > 
> > Oh.  Why?  Please can we have a description of what's wrong with the
> > current code?
> 
> As I replied in another thread [1], this fix and commit 0ef8faff490be
> together make up the complete patch originally sent by Usama [2], so
> they should be squashed together.

0ef8faff490be is upstream so they can't be squashed!

> Without this fix, all memcg-aware
> nr_cached_objects() will be skipped during memcg-level shrinking.
> Besides the newly added memcg-aware shmem huge shrinker, XFS will also
> run into issues.

OK, please add this info to this patch's changelog.  Please also decide
whether a cc:stable should be added and if so, ensure the changelog
makes clear why we're recommending a backport.

As part of this, let's expand on "XFS will also run into issues".

Thanks.