Re: [PATCH 9/9] arm64: dts: qcom: ipq9574: Flatten usb controller node
From: George Moussalem
Date: Sat Aug 29 2026 - 23:15:55 EST
On 8/29/26 20:44, Krishna Kurapati wrote:
>
>
> On 8/25/2026 4:12 PM, George Moussalem via B4 Relay wrote:
>> From: George Moussalem <george.moussalem@xxxxxxxxxxx>
>>
>> Flatten usb controller nodes and update to using latest bindings and
>> flattened driver approach.
>>
>> Add property to the USB node to select UTMI as reference clock for the
>> DWC3 core to calculate the right values for the period and frame length
>> adjustment.
>>
>> Signed-off-by: George Moussalem <george.moussalem@xxxxxxxxxxx>
>
> [...]
>
>> @@ -780,32 +777,31 @@ usb3: usb@8af8800 {
>> assigned-clock-rates = <200000000>,
>> <24000000>;
>> - interrupts-extended = <&intc GIC_SPI 134
>> IRQ_TYPE_LEVEL_HIGH>,
>> + interrupts-extended = <&intc GIC_SPI 140
>> IRQ_TYPE_LEVEL_HIGH>,
>> + <&intc GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>,
>> <&intc GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>,
>> <&intc GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>,
>> <&intc GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
>> - interrupt-names = "pwr_event",
>> + interrupt-names = "dwc_usb3",
>> + "pwr_event",
>> "qusb2_phy",
>> "dm_hs_phy_irq",
>> "dp_hs_phy_irq";
>>
>
> You are adding pwr_event irq here. So please mention that in commit
> message. Or would be better if you can send this interrupt addition as a
> separate patch.
I think you may have misread, I'm not adding the pwr_event irq. It was
already there. I'm simply moving up the dwc_usb3 irq from the dwc node.
>
> Regards,
> Krishna,
Best regards,
George