Re: [PATCH 2/4] arm64: dts: amlogic: t7: fix the pin groups of two PWM outputs

[Neil Armstrong]

On 8/29/26 11:47, Lucas Tanure wrote:
> Two of the PWM outputs can each appear on more than one pin, but the
> description named a single group that does not exist, so anything using
> it refused to start.
>
> Name the real groups instead, one entry per pin, the same way the other
> multi-pin PWM output is already described.
>
> Fixes: 2a2a7b9701a7 ("arm64: dts: amlogic: t7: Add PWM pinctrl nodes")
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: Lucas Tanure <tanure@xxxxxxxxx>
> ---
>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 32 ++++++++++++++++++---
>   1 file changed, 28 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> index c3dc479b137d..8c4bd683cce0 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> @@ -458,9 +458,25 @@ mux {
>   					};
>   				};
>   
> -				pwm_ao_g_pins: pwm-ao-g {
> +				pwm_ao_g_d11_pins: pwm-ao-g-d11 {
>   					mux {
> -						groups = "pwm_ao_g";
> +						groups = "pwm_ao_g_d11";
> +						function = "pwm_ao_g";
> +						bias-disable;
> +					};
> +				};
> +
> +				pwm_ao_g_d7_pins: pwm-ao-g-d7 {
> +					mux {
> +						groups = "pwm_ao_g_d7";
> +						function = "pwm_ao_g";
> +						bias-disable;
> +					};
> +				};
> +
> +				pwm_ao_g_e_pins: pwm-ao-g-e {
> +					mux {
> +						groups = "pwm_ao_g_e";
>   						function = "pwm_ao_g";
>   						bias-disable;
>   					};
> @@ -474,9 +490,17 @@ mux {
>   					};
>   				};
>   
> -				pwm_ao_h_pins: pwm-ao-h {
> +				pwm_ao_h_d5_pins: pwm-ao-h-d5 {
> +					mux {
> +						groups = "pwm_ao_h_d5";
> +						function = "pwm_ao_h";
> +						bias-disable;
> +					};
> +				};
> +
> +				pwm_ao_h_d10_pins: pwm-ao-h-d10 {
>   					mux {
> -						groups = "pwm_ao_h";
> +						groups = "pwm_ao_h_d10";
>   						function = "pwm_ao_h";
>   						bias-disable;
>   					};

Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>

Thanks,
Neil