Re: [PATCH] i2c: mux: avoid WARN on benign symlink creation failures
From: Peter Rosin
Date: Sun Aug 30 2026 - 17:15:05 EST
Den Sun, Aug 30, 2026 at 09:13:24PM +0200, skrev Andi Shyti:
> Hi Peter,
>
> On Sun, Aug 30, 2026 at 06:13:03AM +0200, Peter Rosin wrote:
> > WARN() is a bit harsh and causes a crash for panic-on-warn users. Degrade
> > the error reporting to ordinary dev_err() calls.
> >
> > Reported-by: Farhad Alemi <farhad.alemi@xxxxxxxxxxxx>
> > Link: https://lore.kernel.org/all/CA+0ovCij3QDLRzt8CwpjBy-BbJ5Zf5SV9w9QZXz8uD3Agws31g@xxxxxxxxxxxxxx/
> > Signed-off-by: Peter Rosin <peda@xxxxxxxxxxxxxx>
> > ---
> >
> > Hi Farhad,
> >
> > I assume this patch helps?
>
> I sent this patch for a quick test:
>
> https://lore.kernel.org/all/20260828135950.454799-1-andi.shyti@xxxxxxxxxx/
>
> Maybe they can be taken together, as I agree not to fire a WARN()
> there.
Hi Andi,
[sorry for droping you from cc, that was unintentional]
Yes, sure! And fixing the root cause is of course always nice, good one!
Cheers,
Peter