Re: asus-laptop: Fn hotkeys no longer work on ThinkPad SL400 after 378500dc1313 ("platform/x86: asus-laptop: Register ACPI notify handler directly")

[Armin Wolf]

Am 30.08.26 um 16:41 schrieb Mo Jun:

> Hi Armin Wolf,
>
> On Sun, Aug 30, 2026 at 9:26 PM Mo Jun <royclark086@xxxxxxxxx> wrote:
> > Hi Armin Wolf,
> >
> > On Sun, Aug 30, 2026 at 7:59 PM Armin Wolf <W_Armin@xxxxxx> wrote:
> > > [...]
> > >
> > > I think i found the culprit, could you please test the attached patch?
> > Build the module with the patch(only "make -C .
> > M=drivers/platform/x86") and load the built
> > drivers/platform/x86/asus-laptop.ko, now the Fn hotkeys works again.
> I found that after rmmod the built module, it can not be insmod again.
> Also the system experienced NULL pointer dereferences in
> acpi_bus_generate_netlink_event() which may related to the built
> module.
>
> I guess these was caused that the patch only change calling to
> acpi_dev_install_notify_handler(), not
> acpi_dev_remove_notify_handler().
> After change ACPI_DEVICE_NOTIFY to ACPI_ALL_NOTIFY in calling to
> acpi_dev_remove_notify_handler()(see attached patch), now the module
> can be insmod again after once rmmod.
>
> Regards,
> Jun MO

Good catch, i will send the fixed patch soon.

Thanks,
Armin Wolf