Re: [PATCH v6] staging: iio: adc: ad7816: Use modern IIO attribute macros
From: Jonathan Cameron
Date: Sun Aug 30 2026 - 19:10:08 EST
On Fri, 28 Aug 2026 03:47:21 +0600
"Md. Mahmudul Hasan Mabud" <mdmahmudulhasan1511@xxxxxxxxx> wrote:
> Replace the legacy IIO_DEVICE_ATTR() macros with the modern
> IIO_DEVICE_ATTR_RW() and IIO_DEVICE_ATTR_RO() macros.
>
> This includes renaming driver-specific callback functions to
> standard <name>_show() and <name>_store() formats.
>
> Signed-off-by: Md. Mahmudul Hasan Mabud <mdmahmudulhasan1511@xxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
How did we end up even looking at these? This is converting attributes
that would most likely go away in any attempt to bring this driver out of staging.
I'd much rather see the major surgery needed than tidying up around the edges.
I'm not particularly keen on any effort being expended in this direction
without substantially more justification.
So as this stands I'm going to ignore this one.
Jonathan