Re: [PATCH v7 2/2] iio: adc: ti-ads112c04: Add support for TI ADS112C04

[Jonathan Cameron]

> Add IIO driver support for the Texas Instruments ADS112C04 (16-bit)
> delta-sigma ADCs.
> 
> The driver implements:
> - Single-shot conversions using the IIO raw read interface.
> - Dynamic parsing of single-ended and differential channels from
>   device tree child nodes.
> - Hardware interrupt support via the DRDY pin, falling back to
>   software polling if no IRQ is provided.
> - Per-channel reference source selection (internal 2.048V, external
>   REFP/REFN, or AVDD) via the reference-sources device tree property.
>   refn-supply is not yet supported.
> - Hardware reset via the reset controller framework, falling back to
>   the RESET command when no reset controller is present.
Sashiko pointed out that the reset controller interface doesn't
guarantee what state a reset is in when request succeeds. For
GPIO was are actually fine, but in previous discussions on this we
have decided to go with the rule of the reset subsystem not a specific
implementation - even when we know that one is fine.

Maybe consider a follow up patch to add an explicit reset_assert()

Anyhow that's a minor thing and I didn't find anything else.

For Andy's ndelay - it's not a fast path so I'm fine with fsleep.
If you want to change that, send a follow up on top.

Applied to the testing branch of iio.git. I just rebased that on
rc1 so it will go out as togreg sometime in the next few days.

Thanks,

Jonathan

-- 
Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>