Re: [PATCH v3 1/9] platform/raspberrypi: vchiq-mmal: Include missing headers

[Paul Elder]

Quoting Jai Luthra (2026-07-17 20:04:16)
> The structures defined in mmal-common.h use types related to lists and
> videobuf2 framework, but are missing the explicit includes for them.
> Include those.
> 
> Signed-off-by: Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx>

Reviewed-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx>

> ---
>  drivers/platform/raspberrypi/vchiq-mmal/mmal-common.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/platform/raspberrypi/vchiq-mmal/mmal-common.h b/drivers/platform/raspberrypi/vchiq-mmal/mmal-common.h
> index 6c5092a68b99..c9976bdd7490 100644
> --- a/drivers/platform/raspberrypi/vchiq-mmal/mmal-common.h
> +++ b/drivers/platform/raspberrypi/vchiq-mmal/mmal-common.h
> @@ -16,6 +16,10 @@
>  #ifndef MMAL_COMMON_H
>  #define MMAL_COMMON_H
>  
> +#include <linux/list.h>
> +#include <linux/types.h>
> +#include <media/videobuf2-v4l2.h>
> +
>  #define MMAL_FOURCC(a, b, c, d) ((a) | (b << 8) | (c << 16) | (d << 24))
>  #define MMAL_MAGIC MMAL_FOURCC('m', 'm', 'a', 'l')
>  
> 
> -- 
> 2.54.0
> 
>